Edgewall Software
Modify

Opened 10 years ago

Closed 10 years ago

#12224 closed enhancement (fixed)

Hide Format hints when datetimepicker is present

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Datetime format hints are hidden when JavaScript is enabled.

API Changes:
Internal Changes:

Description

Fields that display a datetimepicker have an adjacent Format string. The string may have had a purpose before the datetimepicker was added (Trac < 1.0), but serves little purpose now. We could hide the strings using jQuery so that the strings are still present for as a no-javascript fallback.

Attachments (0)

Change History (4)

comment:1 by Ryan J Ollos, 10 years ago

Owner: set to Ryan J Ollos
Release Notes: modified (diff)
Status: newassigned

comment:2 by Ryan J Ollos, 10 years ago

Milestone: next-dev-1.1.x1.2

comment:3 by Jun Omae, 10 years ago

It would be good to add class to the container element in the same way as Hide help links feature in preferences instead of directly hiding hints.

  • trac/htdocs/css/trac.css

    diff --git a/trac/htdocs/css/trac.css b/trac/htdocs/css/trac.css
    index be3cd76a3..641377685 100644
    a b div.trac-content {  
    447447#help :link, #help :visited { cursor: help }
    448448#help hr { display: none }
    449449
     450/* Datepicker hints */
     451.trac-nodatetimehint .trac-datetimehint { display: none }
     452
    450453/* Section folding */
    451454.foldable :link, .foldable :visited {
    452455 background: url(../expanded.png) 4px 50% no-repeat;
  • trac/templates/layout.html

    diff --git a/trac/templates/layout.html b/trac/templates/layout.html
    index 664d365d6..b89cb022f 100644
    a b  
    6464        if ($.ui) { /* is jquery-ui added? */
    6565          $(".trac-datepicker:not([readonly])").prop("autocomplete", "off").datepicker();
    6666          $(".trac-datetimepicker:not([readonly])").prop("autocomplete", "off").datetimepicker();
    67           $(".trac-datetimehint").hide();
     67          $("#main").addClass("trac-nodatetimehint");
    6868        }
    6969        $(".trac-disable").disableSubmit(".trac-disable-determinant");
    7070        setTimeout(function() { $(".trac-scroll").scrollToTop() }, 1);

comment:4 by Ryan J Ollos, 10 years ago

Resolution: fixed
Status: assignedclosed

Thanks for reviewing. Committed to trunk with suggested changes in [14345:14347].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.